Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix dependabot config to group docker images #4211

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

spencerschrock
Copy link
Member

@spencerschrock spencerschrock commented Jul 3, 2024

This is apparently required with the current implementation of multi dir PRs.

What kind of change does this PR introduce?

ci update

What is the current behavior?

  • without groups dependabot only updates the deps in the first declared directory, a known bug reported upstream. For example in 🌱 Bump golang from 1.22.3 to 1.22.4 #4160, I had to bump the other 7 occurrences in a manual fix.

What is the new behavior (if this is a feature change)?**

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

This is apparently required with the current implementation of multi dir PRs.

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock requested a review from a team as a code owner July 3, 2024 18:10
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team July 3, 2024 18:10
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.51%. Comparing base (da0f2b4) to head (7cc2926).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4211      +/-   ##
==========================================
+ Coverage   60.17%   66.51%   +6.34%     
==========================================
  Files         212      230      +18     
  Lines       15556    16543     +987     
==========================================
+ Hits         9361    11004    +1643     
+ Misses       5492     4837     -655     
+ Partials      703      702       -1     

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @spencerschrock!

@justaugustus justaugustus merged commit 4895019 into ossf:main Jul 3, 2024
42 checks passed
@spencerschrock spencerschrock deleted the group-dependabot-mutlidir branch July 3, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants